complete function should be a method of the Release singleton
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects can override it
Fixes #9
| console.log( "Release complete." ); | ||
| console.log( "Please review the project-specific release checklist." ); | ||
| } | ||
| Release.define({ |
There was a problem hiding this comment.
Now that this is part of Release, it should just move up to the initial definition.
|
This commit message doesn't conform to our new standards. Please include a component (Release), reduce the length of the summary, and use |
|
I had to squash this since you added a second commit instead of amending. I also updated the commit message to start with a capital letter and not use backticks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so projects can override it
Fixes #9